Conversation
amusingaxl
reviewed
Mar 2, 2026
amusingaxl
reviewed
Mar 2, 2026
amusingaxl
reviewed
Mar 2, 2026
amusingaxl
reviewed
Mar 2, 2026
Comment on lines
+216
to
+218
| assertTrue(uniqueOsmIlk != bytes32(0)); | ||
| assertTrue(sharedOsmIlk != bytes32(0)); | ||
| assertTrue(noOsmIlk != bytes32(0)); |
Contributor
There was a problem hiding this comment.
What are you trying to prove here? That there is at least one ilk that is unique, at least one that is shared and at least one that doesn't have an OSM?
Contributor
Author
There was a problem hiding this comment.
Yes, to test all the scenarios. If it makes more sense, I can just make it optional and prove that the test works for the existing types of ilks
Contributor
There was a problem hiding this comment.
Yeah, I don't think those assertions add a lot of value tbh.
Let's focus on the problem the OmegaPoker tries to solve.
0xLaz3r
force-pushed
the
foundry-migration
branch
from
4fb5abb to
ca19fd3
Compare
amusingaxl
approved these changes
Mar 30, 2026
SidestreamBurningBanana
approved these changes
Mar 31, 2026
SidestreamBurningBanana
left a comment
SidestreamBurningBanana
left a comment
There was a problem hiding this comment.
Approving after being able to run the tests and deploy locally using scripts from updated Makefile:
[⠊] Compiling...
[⠢] Compiling 23 files with Solc 0.6.12
[⠆] Solc 0.6.12 finished in 1.15s
Compiler run successful!
Ran 1 test for src/MegaPoker.t.sol:MegaPokerTest
[PASS] test_poke() (gas: 754305)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 5.84s (4.93s CPU time)
Ran 6 tests for src/OmegaPoker.t.sol:OmegaPokerTest
[PASS] testPoke() (gas: 855538)
[PASS] testPokeCost() (gas: 804253)
[PASS] testRefresh() (gas: 842893)
[PASS] testRefreshCost() (gas: 360381)
[PASS] testRefreshZeroPip() (gas: 524302)
[PASS] test_poke() (gas: 804525)
Suite result: ok. 6 passed; 0 failed; 0 skipped; finished in 8.21s (11.95s CPU time)
Ran 2 test suites in 27.65s (14.05s CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests)
[⠊] Compiling...
No files changed, compilation skipped
Enter keystore password:
Deployer: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
Deployed to: 0x503B47B13a02DA3Eb3f592F6c4aF312D1962c6D7
Transaction hash: 0x984e7ccad01d058fe97d524a0b7457e24ed8c5f4840a068837c66f373cfd3c01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from dapp-tools to Foundry framework
Included the fix for one pre-existing failing test
Closes #56