Skip to content

Fix a few things, add incremental logging, some other things#7

Open
XertroV wants to merge 1 commit intoskybaks:masterfrom
XertroV:master
Open

Fix a few things, add incremental logging, some other things#7
XertroV wants to merge 1 commit intoskybaks:masterfrom
XertroV:master

Conversation

@XertroV
Copy link
Copy Markdown

@XertroV XertroV commented May 13, 2025

So this PR isn't necessarily meant to be merged, but I wanted to share some changes I have made.
There are the host/directory changes for supporting WSL, but in the past few weeks I also added changes to support larger plugins better (E++). Mostly this is around incremental logging.

I also fixed some issues with socket usage so that it would connect reliably.

can't remember why I changed some of the data_length stuff but I haven't noticed any issues.

The _get_next_brackets changes were to support starting midline using -b with getlogs. The -b option was just a cheap way to try and get the last logs (by default, getlogs will wait for the next logs)

summary:

  • getlogs command and incremental logging (print out file as we're waiting for the plugin to reload, instead of at the end)
  • print error msgs at end of logs (long logs mean you have to scroll up otherwise)
  • fix socket handling to not drop connections randomly
  • refactor how logs are printed so getlogs and load use the same logic
  • support using from WSL (obviously overlaps with Add argument to configure the openplanet host address #6)

… logs only command, some logging on plugin side, and misc changes
@skybaks
Copy link
Copy Markdown
Owner

skybaks commented May 13, 2025

Thanks for taking the time to post. At a glance, the server-side changes look to be doing quite a better job about error handling w.r.t the socket connection. I also really like the idea of handling the log with a context manager and monitoring the entire time the client is running.
I'll have to take some time to sit down and wrap my head around all the python client changes. I'm not sure why I never merged #6 but I have gotten a much better understanding of using WSL in the last 6 months so I can approach the issue with at least some level of competence now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants