Fix a few things, add incremental logging, some other things#7
Open
XertroV wants to merge 1 commit intoskybaks:masterfrom
Open
Fix a few things, add incremental logging, some other things#7XertroV wants to merge 1 commit intoskybaks:masterfrom
XertroV wants to merge 1 commit intoskybaks:masterfrom
Conversation
… logs only command, some logging on plugin side, and misc changes
Owner
|
Thanks for taking the time to post. At a glance, the server-side changes look to be doing quite a better job about error handling w.r.t the socket connection. I also really like the idea of handling the log with a context manager and monitoring the entire time the client is running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this PR isn't necessarily meant to be merged, but I wanted to share some changes I have made.
There are the host/directory changes for supporting WSL, but in the past few weeks I also added changes to support larger plugins better (E++). Mostly this is around incremental logging.
I also fixed some issues with socket usage so that it would connect reliably.
can't remember why I changed some of the
data_lengthstuff but I haven't noticed any issues.The
_get_next_bracketschanges were to support starting midline using-bwithgetlogs. The-boption was just a cheap way to try and get the last logs (by default, getlogs will wait for the next logs)summary:
getlogscommand and incremental logging (print out file as we're waiting for the plugin to reload, instead of at the end)getlogsandloaduse the same logic