Skip to content

Fix terminal garbage on WebSocket reconnect #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0pcom merged 1 commit into from
Mar 6, 2026
Merged

Fix terminal garbage on WebSocket reconnect #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/dmsgpty/ui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ func (ui *UI) Handler(customCommands map[string][]string) http.HandlerFunc {
}
defer func() { log.WithError(ws.Close(websocket.StatusNormalClosure, "closed")).Debug("Closed ws.") }()

wsConn := websocket.NetConn(r.Context(), ws, websocket.MessageText)
// Use binary mode for PTY data - text mode fails on non-UTF-8 bytes
wsConn := websocket.NetConn(r.Context(), ws, websocket.MessageBinary)

// open pty
logWS(wsConn, "Dialing...")
Expand Down
3 changes: 1 addition & 2 deletions pkg/dmsgpty/ui_html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4318,7 +4318,6 @@ func writeTermHTML(w io.Writer) (int64, error) {
if err != nil {
return 0, err
}
defer gz.Close() //nolint

return io.Copy(w, gz) //nolint:gosec // HTML is trusted content
return io.Copy(w, gz) //nolint:gosec // G110: embedded content is trusted
}
Loading