Audit/codebase review#355
Merged
0pcom merged 4 commits intoskycoin:developfrom Mar 29, 2026
Merged
Conversation
- Replace panic with error return in updateServerEntry for empty addr - Fix integer underflow in available sessions calculation (clamp to 0) - Fix deadlock risk: move session callbacks outside sessionsMx lock, have callbacks acquire lock themselves to avoid recursive locking - Fix double-close in SessionCommon.Close: use else-if so only the active mux (smux or yamux) is closed, not both - Fix unbounded backoff growth when maxBO is 0 - Add logging when listener accept buffer is full (was silent drop) - Log when error channel is full and errors are dropped
- Replace panic() with error return in hostMux.Handle and ServeConn path match — prevents crashes from malformed URL patterns - Cap PtyGateway.Read allocation to 64KB to prevent memory exhaustion from malicious or buggy RPC requests - Add MaxHeaderBytes (16KB) to dmsghttp server to mitigate slowloris - Remove stray println() debug output in dmsgpty-cli - Fix context.Background() replacing parent context in dmsghttp proxy setup — signal cancellation was being lost - Add 50ms backoff on temporary accept errors in dmsgpty host to prevent CPU spin on persistent transient errors
When output is a directory, the URL path was joined directly without sanitization, allowing paths like ../../etc/passwd to escape the intended output directory. Use filepath.Base to extract only the filename component.
Update github.com/skycoin/skywire to a5facdc74e72d4a3562e90cf7318e0f235b6d48f Also updates skycoin, pgx, goldmark, and resolves genproto module conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.