Skip to content

Improve _q function with safe division #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucaPizzagalli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve _q function with safe division #1103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion skyfield/almanac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,9 @@ def _transit_ha(latitude, declination, altitude_radians):

def _q(a, b, c, sign):
discriminant = np.maximum(b*b - 4*a*c, 0.0) # avoid tiny negative results
return - 2*c / (b + sign * sqrt(discriminant))
denominator = b + sign * sqrt(discriminant)
q = np.zeros_like(denominator)
return np.divide(-2 * c, denominator, out=q, where=(denominator != 0))

def _intersection(y0, y1, v0, v1):
# Return x at which a curve reaches y=0, given its position and
Expand Down