Skip to content

Tighten tolerances in event finding routines #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshPaterson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tighten tolerances in event finding routines #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skyfield/searchlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def _find_discrete(ts, jd, f, epsilon, num):
y = y.take(indices + 1)
# Keep only the last of several zero crossings that might
# possibly be separated by less than epsilon.
mask = concatenate(((diff(ends) > 3.0 * epsilon), (True,)))
mask = concatenate(((diff(ends) > epsilon), (True,)))
ends = ends[mask]
y = y[mask]
break
Expand Down
2 changes: 1 addition & 1 deletion skyfield/sgp4lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def below_horizon_at(t):
doublets = repeat(concatenate(((t0.tt,), jdmax, (t1.tt,))), 2)
jdo = (doublets[:-1] + doublets[1:]) / 2.0

trs, rs = _find_discrete(t0.ts, jdo, below_horizon_at, half_second, 8)
trs, rs = _find_discrete(t0.ts, jdo, below_horizon_at, half_second/4, 8)

jd = concatenate((jdmax, trs.tt))
v = concatenate((ones, rs * 2))
Expand Down