Open
Conversation
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Gilberto Estevez <user@local.host>
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pnpm/action-setup/releases">pnpm/action-setup's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <p>An error is thrown if one version of pnpm is specified in the <code>packageManager</code> field of <code>package.json</code> and a different version is specified in the action's settings <a href="https://redirect.github.com/pnpm/action-setup/pull/122">#122</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pnpm/action-setup/commit/fe02b34f77f8bc703788d5817da081398fad5dd2"><code>fe02b34</code></a> docs: bump action-setup version in README</li> <li><a href="https://github.com/pnpm/action-setup/commit/bee1f099e575ebe79c239f210b7b841a7597f87b"><code>bee1f09</code></a> feat: throw error when multiple versions specified (<a href="https://redirect.github.com/pnpm/action-setup/issues/122">#122</a>)</li> <li><a href="https://github.com/pnpm/action-setup/commit/ce859e384f8a1a0be70b423054e9fc15175c02a9"><code>ce859e3</code></a> refactor: replace <code>fs-extra</code> with Node.js built-in fs methods (<a href="https://redirect.github.com/pnpm/action-setup/issues/120">#120</a>)</li> <li><a href="https://github.com/pnpm/action-setup/commit/2ab6dce4f53589dada480b94c53cb05a06b04673"><code>2ab6dce</code></a> docs(README): fix link to LICENSE</li> <li><a href="https://github.com/pnpm/action-setup/commit/e280758d01dee817bb34e0eb1114fde6d3a9f1db"><code>e280758</code></a> docs(README): update dependency versions (<a href="https://redirect.github.com/pnpm/action-setup/issues/117">#117</a>)</li> <li><a href="https://github.com/pnpm/action-setup/commit/129abb77bf5884e578fcaf1f37628e41622cc371"><code>129abb7</code></a> Bump undici from 5.28.2 to 5.28.3 (<a href="https://redirect.github.com/pnpm/action-setup/issues/115">#115</a>)</li> <li>See full diff in <a href="https://github.com/pnpm/action-setup/compare/v3...v4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
With newer versions of turbo, there is a new UI for each task that is running. There are 2 reasons I see as a good fit to revert the UI. - It can be difficult to navigate for users who don't have much experience navigating and using the command line - The logs will not show properly in the manager, and will make diagnosing issues difficult for those who use the manager Casper, please let me know your thoughts, and feel free to merge if you agree. Thanks 🙂!
…nd deputies (#1955) ## Feature Added option to return officers and ems deputies related to a User, similar to the logic already in place for Citizens in endpoint ``v1/admin/manage/users/{id}``
Co-authored-by: Roll Alexander <Alexander.Roll@apa.at>
<!-- Thanks for opening a PR! Your contribution is much appreciated! --> ## Bug Many users were experiencing images not loading. This was caused by Next.js deprecating `images.domains` in favor of `images.remotePatterns`. Our script was still written for the old API (adding a domain string via string replace), which no longer matches the current `next.config.mjs` structure and could break or fail to add the deployment origin. ## Changes - **`scripts/create-images-domain.mjs`** - Switched from the deprecated domain-string approach to **`images.remotePatterns`**. - The script now injects a full pattern object (`protocol`, `hostname`, `pathname: "**"`) derived from `NEXT_PUBLIC_PROD_ORIGIN` instead of appending a raw domain string. - Added idempotency: if the hostname is already in `remotePatterns`, the script exits without changing the config. - More robust parsing: locates the `remotePatterns` array and inserts the new entry before the closing `]` instead of using a fragile string replace. - **`package.json`** - The **build** script now runs `node scripts/create-images-domain.mjs` before the Turbo build so the client’s Next config is updated with the correct image remote pattern for the deployment origin before building. - [x] No breaking changes - [x] Formatted with Prettier --- @casperiv0, sorry for the @, I know you're a busy guy! But, ~~I noticed in 1d8f6b5, it removed many parenthesized expressions that wrapped some nullish coalescing operators. I know it's best practice to wrap these in parenthesized expressions, but eslint/prettier complains about it and sees it as unnecessary. I briefly look through, and I personally don't see anything that could affect behavior, but I could be wrong. Let me know if you'd prefer to keep the parentheses and skip a full codebase format, or if you're okay with prettier removing them.~~ EDIT: I reverted the format commit resulting in eslint errors. Let me know if this is good to merge 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
closes: #numberFeature
closes: #numberTranslations
.jsonfiles are formatted:pnpm formati18n.config.mjs