import redo/undo icon files and add to default export#4709
Open
michaelchadwick wants to merge 1 commit intoslab:mainfrom
Open
import redo/undo icon files and add to default export#4709michaelchadwick wants to merge 1 commit intoslab:mainfrom
michaelchadwick wants to merge 1 commit intoslab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the existing Redo and Undo icon
svgtemplates to the default set of available toolbar icons.Why Change?
This feature belongs in Quill core because of three things:
How I'm Using Quill
We are currently attempting to convert from using the paid-for, closed-source Froala to the free, open-source Quill. We will use this embedded text editor in many places in our app where users need to enter long-form data.
Use Case
Our app uses EmberJS, and in order to offer a Redo/Undo button combo in the toolbar, and make sure we avoid a hard-coded practice of copying and pasting the
svgicons from ournode_modulesdirectory (which would make any future updates to Quill more difficult), we are "hacking" in the relevantsvgtemplates intoQuillEditor.import('ui/icons'):This works, but feels unnecessary when the icons are already there and could just be added to the default set.