feat(gm-panel): dual-dial encounter timeline tab#164
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
slabgorb
added a commit
that referenced
this pull request
Apr 25, 2026
* feat(gm-panel): render dual-dial encounter timeline with new event kinds (#164) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(ui): yield button + /yield command Add YieldButton component, wire it into the confrontation overlay, add /yield slash command that sends a YIELD wire message, and thread the onYield callback from App.tsx through GameBoard → ConfrontationWidget → ConfrontationOverlay. MessageType.YIELD added to protocol.ts to mirror the server-side type added in Task 23. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(ui): forward slash-command messages to server send pipeline handleSend was appending slash-command-produced messages (e.g. /yield → YIELD) to local state but never calling send(), so the server's _handle_yield never fired. Add send(msg) for-loop inside the slashResult.messages.length > 0 block; intentionally omit setCanType / setThinking — slash commands do not start a narration turn. Add wiring test (slash-command-send-wiring.test.ts) asserting the for-loop and send(msg) are present inside the slashResult.handled branch and that setCanType/setThinking are absent from that branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 UI deliverable for dual-track momentum. Adds an "⑧ Encounters" tab to the GM Dashboard that renders the new
ENCOUNTER_*event timeline from the server-side SQLite events table.Companion to sidequest-server#54, which adds the
GET /api/sessions/{slug}/encounter_eventsREST endpoint this tab consumes.What's in here
EncounterEventKindunion (9 kinds) andEncounterEventinterface insrc/types/payloads.ts.src/components/Dashboard/tabs/EncounterTab.tsx:EncounterTimeline(pure renderer) — ordered<ol>with per-kind row functions for STARTED, BEAT_APPLIED, METRIC_ADVANCE, BEAT_SKIPPED, TAG_CREATED, STATUS_ADDED, YIELD, RESOLVED. Renders nothing for the internal RESOLUTION_SIGNAL kind.EncounterTab(fetch wrapper) — calls/api/sessions/{slug}/encounter_eventson slug change with proper unmount cancellation; surfaces fetch errors rather than swallowing them (no silent fallbacks).DashboardApp.tsxat index 7; label"⑧ Encounters"added toDashboardTabs.tsx. Active session slug derived fromdebugStateusing the same newest-last_activity_tslogic asStateTab.src/__tests__/EncounterTab.test.tsx: row rendering, dial-pair view, exported-and-importable wiring test, no-session placeholder.Visual context
This is the lie-detector tab from CLAUDE.md's OTEL principle: "If a subsystem isn't emitting OTEL spans, you can't tell whether it's engaged or whether Claude is just improvising." Phase 2 wired the encounter subsystem to write typed event rows; this tab makes them readable post-hoc.
Test plan
npx vitest run src/__tests__/EncounterTab.test.tsx— 4/4 pass.npx tsc --noEmit— clean.🤖 Generated with Claude Code