fix(lobby): MP mode joins existing session before allocating new slug#172
Merged
fix(lobby): MP mode joins existing session before allocating new slug#172
Conversation
Playtest 2026-04-26 S4-UX bug: P2 (different host, no shared local Past Journey state) hit "Start Adventure" in Multiplayer mode and was routed to a fresh ``-2`` slug instead of joining P1's existing table. The companion server fix (sidequest-server fix/s4-mp-lobby-join-existing-server) makes POST /api/games join the existing same-slug MP game by default — this UI change signals that intent in the affordance label so users on a second host understand that clicking Start joins rather than splits. Cosmetic-only: the button still calls handleStart unchanged. The heavy lifting is server-side; this is the QoL signal the architect specified as the minimum-viable UI affordance. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playtest 2026-04-26 S4-UX bug — UI affordance companion to sidequest-server PR #68.
In Multiplayer mode, P2 (on a different host with no shared local Past Journey state) hit "Start Adventure" and was routed to a fresh `-2` slug instead of joining P1's existing table. The server-side fix in PR #68 makes `POST /api/games` join the existing same-slug MP game by default; this UI change signals that intent in the affordance label so users understand that clicking Start in MP mode will join rather than split.
Changes
Why this is minimum-viable
Per architect's recommendation: "For tonight's game, the server-side fix is sufficient and load-bearing. The UI affordance is a quality-of-life improvement that can ship next." The button-text change is the smallest honest signal of the new behavior; a richer "Existing session in progress: [Join]" annotation can ship later without blocking tonight's playtest.
Test plan
Related
🤖 Generated with Claude Code