Skip to content

feat: default manifest source to manifest.json for Bolt Framework projects #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwbrooks wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

feat: default manifest source to manifest.json for Bolt Framework projects #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/project/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ func projectInitCommandRunE(clients *shared.ClientFactory, cmd *cobra.Command, a

// Install the project dependencies, such as .slack/ and runtime packages
// Existing projects initialized always default to config.ManifestSourceLocal.
// The link command will switch it to config.ManifestSourceRemote
_ = create.InstallProjectDependencies(ctx, clients, projectDirPath, config.ManifestSourceLocal)

// Add an existing app to the project
Expand Down
4 changes: 2 additions & 2 deletions internal/pkg/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,12 +521,12 @@ func InstallProjectDependencies(
manifestSource = config.ManifestSourceLocal
}

// Set non-Deno (non-ROSI) projects to ManifestSourceRemote.
// Set non-Deno (non-ROSI) projects to ManifestSourceLocal.
// TODO: should check if Slack hosted project, but the SDKConfig has not been initialized yet.
if clients.Runtime != nil {
isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno")
if !isDenoProject {
manifestSource = config.ManifestSourceRemote
manifestSource = config.ManifestSourceLocal
}
}

Expand Down
4 changes: 2 additions & 2 deletions internal/pkg/create/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,10 +432,10 @@ func Test_Create_installProjectDependencies(t *testing.T) {
`Updated config.json manifest source to "project" (local)`,
},
},
"When non-Deno project, should set manifest source to app settings (remote)": {
"When non-Deno project, should set manifest source to project (local)": {
runtime: "node",
expectedOutputs: []string{
`Updated config.json manifest source to "app settings" (remote)`,
`Updated config.json manifest source to "project" (local)`,
},
},
}
Expand Down
Loading