build!: update node runtime to version 24#567
Conversation
This bumps the Node.js runtime version from `20` to `24`.
|
Thanks for the contribution! Before we can merge this, we need @desrosj to sign the Salesforce Inc. Contributor License Agreement. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 95.92% 99.86% +3.93%
==========================================
Files 14 7 -7
Lines 2697 718 -1979
==========================================
- Hits 2587 717 -1870
+ Misses 110 1 -109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🧪 Our current testing patterns aren't updating the PR status but tests are still passing with these changes: 🔗 https://github.com/slackapi/slack-github-action/actions/runs/23018310756/job/66847533918 |
|
🧪 More tests after more changes to the build: 🔗 https://github.com/slackapi/slack-github-action/actions/runs/23020161698/job/66854119889 |
|
👁️🗨️ I notice the techniques that use |
package.json
Outdated
| "node": ">=20.0.0", | ||
| "npm": ">=10.2.0" | ||
| "node": ">=24.0.0", | ||
| "npm": ">=11.3.0" |
There was a problem hiding this comment.
May I suggest using 24.11.0 and 11.6.1? This was the the version that transitioned 24.x to LTS and the version of npm bundled with it.
There was a problem hiding this comment.
@desrosj TIL about these later moves to LTS! Thanks for sharing this 👾 ✨
We added this in 8d63bbc with findings that runner images support the latest LTS versions and I understand self-hosted runners act similar 🤖
Tool name Installation strategy Node.js 3 latest LTS versions
🔗 https://github.com/actions/runner-images?tab=readme-ov-file#software-and-image-support
| "scripts": { | ||
| "build": "ncc build src/index.js --license licenses.txt --source-map", | ||
| "check": "tsc --noemit --module es2022 --project ./jsconfig.json", | ||
| "dev": "act public --eventpath .github/resources/.actions/event.json --secret-file .github/resources/.env --platform ubuntu-latest=node:20-buster --container-architecture linux/amd64", |
| description: "The timestamp of a Slack message or event in the response." | ||
| runs: | ||
| using: "node20" | ||
| using: "node24" |
There was a problem hiding this comment.
🔭 note: This is the change that's surfaced for actioneers using this step!
https://nodejs.org/en/blog/release/v24.11.0 Co-authored-by: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com>
|
🧪 Most recent tests: 🔗 https://github.com/slackapi/slack-github-action/actions/runs/23021657814/job/66859311342 |
|
🧪 With a final test run: 🔗 https://github.com/slackapi/slack-github-action/actions/runs/23021909593/job/66860212768 |
|
Thanks @zimeg! |
Summary
This bumps the Node.js runtime version from
20to24.GitHub has begun deprecating Node20 and workflows using the
slack-github-actionaction are now seeing the following notice on workflow runs:Requirements