Implementing simulated liquid level response #120
Open
ssoham wants to merge 6 commits intoslaclab:masterfrom
Open
Implementing simulated liquid level response #120ssoham wants to merge 6 commits intoslaclab:masterfrom
ssoham wants to merge 6 commits intoslaclab:masterfrom
Conversation
ssoham
commented
Aug 23, 2024
ssoham
commented
- liquid level response based on JT stable position and current manual JT position
- basic PID implementation has been included -- constants need to be adjusted so that auto JT positioning does not blow up immediately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.