fix: exponential backoff and WaitingForSigning phase for CSR polling (#112)#127
Merged
fix: exponential backoff and WaitingForSigning phase for CSR polling (#112)#127
Conversation
…#112) Replace fixed 5s requeue interval with exponential backoff (5s -> 30s -> 2min -> 5min) based on poll attempt count tracked via annotation on the pending Secret. After 10 failed attempts, transition to a new WaitingForSigning phase with a warning event guiding users to manually sign the CSR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on #126 by @mathildabot with CRD manifest fix.
Closes #112
Test plan
make generate manifestsproduces no diffgo build ./...passesgo vet ./...passesgo test ./internal/controller/...passes