Open
Conversation
Add spec.external to CertificateAuthority, allowing the operator to delegate CSR signing and CRL fetching to an external Puppet/OpenVox CA running outside the cluster with optional mTLS client authentication.
Avoids Go 1.26 go fmt smart quote regression (#30).
Add 13 new tests covering reconcileExternalCA, buildExternalCAHTTPClient, and external CA phase acceptance in the certificate controller. - testutil_test.go: add caOption type with withExternal, withExternalCASecret, withExternalTLSSecret, withExternalInsecureSkipVerify options - certificateauthority_controller_test.go: 6 tests for external CA reconciler (basic flow, custom CA secret, missing secret, missing key, no PVC/Job, no Config) - certificate_controller_test.go: 1 test for External phase acceptance - certificate_signing_test.go: 6 tests for buildExternalCAHTTPClient (minimal, insecure skip verify, CA secret, missing secret, mTLS, missing key)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.externaltoCertificateAuthorityfor connecting to an external Puppet/OpenVox CA running outside the clusterExternalphase to CA lifecycle, accepted byCertificatecontroller alongsideReadybuildExternalCAHTTPClient()andcaHTTPClientForCA()methodsexternaland customstorageare mutually exclusiveCloses #54
Replaces #133 and #134
Files Changed
api/v1alpha1/certificateauthority_types.go--ExternalCASpecstruct,Externalfield, CEL validation,Externalphaseinternal/controller/certificateauthority_controller.go--reconcileExternalCA()methodinternal/controller/certificateauthority_crl.go--caBaseURLresolution,caHTTPClientForCA()internal/controller/certificate_controller.go-- acceptExternalphase, resolvecaBaseURLinternal/controller/certificate_signing.go--caHTTPClientForCA(),caServiceName->caBaseURLconfig/samples/certificateauthority-external.yaml-- example with external CA + mTLSdocs/guides/ca-import.md-- guide covering CA import and external CA setupTest plan
make generate-- deepcopy generation succeedsmake manifests-- CRD manifests regenerated with new fieldsmake build-- compiles without errorsgo test ./internal/controller/...-- all existing unit tests pass