Skip to content

Conversation

@Naveenrajp26
Copy link

Added the tcp support

@Naveenrajp26 Naveenrajp26 mentioned this pull request Jan 17, 2025
@slayercat
Copy link
Owner

I appreciate the contribution

Furthermore, upon initial review, this implementation does not account for the length field in the protocol. It needs to be supplemented based on RFC3430[1].

Additionally, if you could provide a unit test, I would be very grateful.

[1] http://www.faqs.org/rfcs/rfc3430.html

   It is possible that the underlying TCP implementation delivers byte
   sequences that do not align with SNMP message boundaries.  A
   receiving SNMP engine MUST therefore use the length field in the
   BER-encoded SNMP message to separate multiple requests sent over a
   single TCP connection (framing).  An SNMP engine which looses framing
   (for example due to ASN.1 parse errors) SHOULD close the TCP
   connection.  The connection initiator will then be responsible for
   establishing a new TCP connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants