packaging: remove cythonized files#40
Open
drewrisinger wants to merge 1 commit intoslaypni:masterfrom
Open
Conversation
See slaypni#13. Issue is that the cythonized .pyx file can stop matching CPython APIs across Python versions, and that the .cpp file is automatically used if it exists. This causes the Cython build to fail. The gitignore change prevents .cpp files from being added in future and adds a note about why not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #13. Issue is that the cythonized .pyx file can stop matching CPython APIs across Python versions, and that the .cpp file is automatically used if it exists. This causes the Cython build to fail.
The gitignore change prevents .cpp files from being added in future and adds a note about why not.