fix(cython): replace fallback import for INFINITY import in _fastdtw.pyx#66
Open
QuirkyCroissant wants to merge 1 commit intoslaypni:masterfrom
Open
fix(cython): replace fallback import for INFINITY import in _fastdtw.pyx#66QuirkyCroissant wants to merge 1 commit intoslaypni:masterfrom
QuirkyCroissant wants to merge 1 commit intoslaypni:masterfrom
Conversation
- Removed faulty fallback `from numpy.math cimport INFINITY` - Replaced with `from libc.math cimport INFINITY`, which resolves build errors - Fixes Cython compilation and enables proper FastDTW C extension usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a build error that occurs when compiling FastDTW from source.
The Cython file
_fastdtw.pyxcontains a fallbackcimportfromnumpy.math, which does not exist and breaks the build process.from libc.math cimport INFINITYThis removes the broken fallback and ensures proper compilation of the C extension.
Without this fix, the build fails and FastDTW falls back to the pure Python implementation, which is up to 50× slower.
With the fix, the compiled
.soextension is correctly built and used, unlocking FastDTW's intended performance.NumPy seemingly removed
numpy.math.pxdin version 2.0.0 as noted in their changelog:https://github.com/numpy/numpy/blob/main/doc/changelog/2.0.0-changelog.rst
Related Issue
Closes #65
Let me know if any changes are needed — happy to adjust.