Revert "Add support for lyrat mini v1.2 and es8311"#548
Revert "Add support for lyrat mini v1.2 and es8311"#548philippe44 merged 1 commit intomaster-cmakefrom
Conversation
Summary of ChangesHello @philippe44, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completely reverts the changes introduced in PR #165, effectively removing the previously added support for the ESP32 LyraT Mini v1.2 development board and the ES8311 DAC. This action ensures that the codebase no longer includes the specific hardware configurations and documentation related to these components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts the addition of support for the LyraT mini v1.2 board and the ES8311 DAC. The changes correctly remove the relevant documentation from README.md and the codec configuration from components/squeezelite/external/dac_external.c. The revert appears to be clean and complete, with no dangling references or leftover code from the original changes. This is a straightforward revert and looks good to merge.
Reverts #165