Skip to content

Revert "Add support for lyrat mini v1.2 and es8311"#548

Merged
philippe44 merged 1 commit intomaster-cmakefrom
revert-165-es8311
Feb 16, 2026
Merged

Revert "Add support for lyrat mini v1.2 and es8311"#548
philippe44 merged 1 commit intomaster-cmakefrom
revert-165-es8311

Conversation

@philippe44
Copy link
Copy Markdown
Collaborator

Reverts #165

@philippe44 philippe44 merged commit 602af3c into master-cmake Feb 16, 2026
2 of 4 checks passed
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @philippe44, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completely reverts the changes introduced in PR #165, effectively removing the previously added support for the ESP32 LyraT Mini v1.2 development board and the ES8311 DAC. This action ensures that the codebase no longer includes the specific hardware configurations and documentation related to these components.

Highlights

  • Reverted LyraT Mini v1.2 Support: The changes introduced in PR Add support for lyrat mini v1.2 and es8311 #165, which added support for the ESP32 LyraT Mini v1.2 development board, have been fully reverted.
  • Removed ES8311 DAC Configuration: The ES8311 DAC model and its associated initialization sequence have been removed from the recognized DAC configurations.
  • Documentation Update: The README.md file was updated to remove all documentation pertaining to the ESP32 LyraT Mini v1.2 board and the ES8311 DAC.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • README.md
    • Removed the "ESP32 LyraT Mini v1.2" section.
    • Removed "ES8311" from the list of recognized DAC models.
  • components/squeezelite/external/dac_external.c
    • Removed the es8311 entry from the dac_config_table, which contained its initialization JSON string.
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the addition of support for the LyraT mini v1.2 board and the ES8311 DAC. The changes correctly remove the relevant documentation from README.md and the codec configuration from components/squeezelite/external/dac_external.c. The revert appears to be clean and complete, with no dangling references or leftover code from the original changes. This is a straightforward revert and looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant