Skip to content

Maintenance improvements #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-sayers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Maintenance improvements #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd6127
Update maintenance-timer for github-script@v5
andrew-sayers Feb 7, 2022
1a25fff
Maintenance-related readability improvements
andrew-sayers Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/ISSUE_TEMPLATE/planned-maintenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This issue tracks a period of planned maintenance. For example, an update that

**Reason for maintenance:** TODO: one line explanation of why this maintenance is required
**Issues to be aware of:** TODO: e.g. will the site break? Will actions behave strangely?
**More information:** see the [maintenance actions checklist](https://sleepdiary.github.io/internal-tools/maintenance-actions.html)
**More information:** see the [maintenance actions checklist](https://andrew-sayers.github.io/planned-maintenance/#https://sleepdiary.github.io/planned-maintenance-info/index.js)

## Planning

Expand All @@ -30,19 +30,19 @@ Some automations are based on these times. No-one will mind if you manually clo

## Fallback plan

1. [ ] check the fallback plan below, modify it or write a new one as necessary
2. [ ] be prepared to use these steps at the time you promised
3. [ ] make sure this plan will take less than half an hour to run

Steps to revert this maintenance:
1. `git pull && git revert last-known-good..main && git push` in each modified branch
2. re-run any relevant workflows

1. [ ] check the fallback plan above, modify it or write a new one as necessary
2. [ ] be prepared to use these steps at the time you promised
3. [ ] make sure this plan will take less than half an hour to run

## Procedure

1. [ ] final check of [the maintenance actions](https://github.com/sleepdiary/planned-maintenance-info/edit/main/index.js)
2. [ ] confirm that all items before this one have been ticked off
3. [ ] follow [the maintenance actions](https://github.com/sleepdiary/planned-maintenance-info/edit/main/index.js)
3. [ ] follow [the maintenance checklist](https://andrew-sayers.github.io/planned-maintenance/#https://sleepdiary.github.io/planned-maintenance-info/index.js)
4. [ ] add a comment to any waiting branches that it's now safe to merge

## Review and process improvements
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/maintenance-timer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

function send_message(body) {
console.log("Sending:\n" + body);
github.issues.createComment({
github.rest.issues.createComment({
issue_number: issue,
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
break;

default:
console.log(`Not sending - time_before_start == ${time_before_start}`);
console.log(`Not sending - time_before_start == ${time_before_start} half-hour blocks`);

}

Expand Down