enable workspace configuration#196
Merged
ubnt-intrepid merged 1 commit intoslog-rs:masterfrom Oct 24, 2018
Merged
Conversation
dpc
approved these changes
Oct 23, 2018
ubnt-intrepid
force-pushed
the
workspace
branch
from
c8b7adc to
2c6b930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature flag
use_extern_macrosis stabilized at 1.30 and the fieldedition = '2018'inCargo.tomlis no longer required.This PR register
test_edition2018into the member of workspace in order to sharetarget/. (Since the oldcargorejects the crate when someone in the members of workspace haseditionfield, the test crate was completely separated.)The item
[workspace]will be removed at publishing and hence there is no affect to the released crates.Edited: blocked on #197 due to fix nightly regression.