Reordered linking - plase don't merge blindly#7
Open
kkauder wants to merge 1 commit intosly2j:masterfrom
Open
Conversation
Collaborator
Author
|
There's more to it, actually. I built BeAGLE using all four libraries and it quietly overrode my LHAPDF linking. I need to specifically only use |
Owner
|
Maybe we could export some extra targets for those cases? I can't really test your changes (no time right now) but it does seem reasonable to me at first glance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found while hacking up PEPSI by hand
https://gitlab.com/eic/mceg/pepsi/-/commit/84ca2fd52e8e0ff3a84da73c768a2eb12e1efdde
that repetition isn't enough.
It may actually not even be needed. If that's the case, l. 39,
can be deleted too.
But I don't have enough test cases to be comfortable just pulling this change in. Opinions?