Skip to content

Fix popup re-enable toolbar lifecycle#56

Merged
sm17p merged 2 commits intomainfrom
fix/popup-reenable-toolbar
Mar 27, 2026
Merged

Fix popup re-enable toolbar lifecycle#56
sm17p merged 2 commits intomainfrom
fix/popup-reenable-toolbar

Conversation

@sm17p
Copy link
Copy Markdown
Owner

@sm17p sm17p commented Mar 27, 2026

Summary

  • keep EventsManager mounted while inspector UI modules remain gated by active state
  • restore EXTENSION_TOGGLE handling inside EventsManager with source/state guards so popup off/on works without reload
  • add a patch changeset and regression coverage for popup off -> on toolbar recovery

Test plan

  • pnpm check
  • pnpm lint
  • pnpm test:e2e --grep \"popup toggle off and on restores toolbar without reload\"

Closes #55

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 4c8ab21

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sm17p sm17p merged commit 90bed9e into main Mar 27, 2026
2 checks passed
@sm17p sm17p deleted the fix/popup-reenable-toolbar branch March 27, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolbar does not return after popup disable/re-enable

1 participant