Skip to content

Upgrade Lucide and fix toolbar voting controls and e2e tests#57

Merged
sm17p merged 1 commit intomainfrom
fix/toolbar-voting-and-lucide
Mar 27, 2026
Merged

Upgrade Lucide and fix toolbar voting controls and e2e tests#57
sm17p merged 1 commit intomainfrom
fix/toolbar-voting-and-lucide

Conversation

@sm17p
Copy link
Copy Markdown
Owner

@sm17p sm17p commented Mar 27, 2026

Summary

  • Upgrade @lucide/svelte to v1 and align WXT skill notes.
  • Fix Svelte state_referenced_locally warnings (Tracker, DebugToolbar, UpvoteAction).
  • Fix duplicate DOM IDs from useId() call-site cache: use generateId per instance for Switch, Tooltip, and UpvoteAction; rename vote prop to voteKey (Svelte reserves key).
  • E2e: import attributes for package.json in popup spec; Feature Voting smoke (multi-on + isolation); remove forced clicks where possible; narrow aria-pressed for TypeScript.
  • Misc: ToolbarSettings / DebugToolbar and related files as in branch.

Test plan

  • pnpm check / pnpm lint
  • pnpm build && pnpm exec playwright test

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 27, 2026

⚠️ No Changeset found

Latest commit: 6b3af36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sm17p sm17p merged commit 1652455 into main Mar 27, 2026
1 of 2 checks passed
@sm17p sm17p deleted the fix/toolbar-voting-and-lucide branch March 27, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant