Skip to content

Stabilize toolbar settings reopen assertion in e2e#58

Merged
sm17p merged 1 commit intomainfrom
fix/toolbar-voting-and-lucide
Mar 27, 2026
Merged

Stabilize toolbar settings reopen assertion in e2e#58
sm17p merged 1 commit intomainfrom
fix/toolbar-voting-and-lucide

Conversation

@sm17p
Copy link
Copy Markdown
Owner

@sm17p sm17p commented Mar 27, 2026

Summary

  • Restore Auto-Hide persistence check in the same toolbar settings test after menu close/reopen.
  • Make reopen deterministic with openToolbarSettingsUntilVisible(...) and scope post-reopen assertion through visible menu context.
  • Keep non-force clicks while reducing CI flake risk.

Test plan

  • pnpm build
  • pnpm exec playwright test e2e/tests/toolbar-settings.spec.ts --repeat-each=8
  • pnpm exec playwright test

Made with Cursor

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 27, 2026

⚠️ No Changeset found

Latest commit: 1ebe281

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sm17p sm17p merged commit d7948b0 into main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant