-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade react native 0.79.4 + Removed Mixpanel from Native Android/IOS SDKs #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Upgrade react native 0.79.4 + Removed Mixpanel from Native Android/IOS SDKs #106
Conversation
Use react-native 0.79.4 to setup the app
Updated the version of react-native-screens to ^3.34.0 in package.json and modified the Android build.gradle to include jcenter in the repositories list. Also, adjusted gradle.properties to disable new architecture and added artifactory credentials.
Swapped the API categories in PrivacyInfo.xcprivacy and updated the project.pbxproj to include PrivacyInfo.xcprivacy in the Resources build phase. Adjusted build settings to include new flags and development team information.
Added multiple screens and components for the smart investing app, including ConnectScreen, HoldingsScreen, and SmtScreen. Introduced context providers for environment and SST cart management. Integrated API functions for handling user interactions and data fetching. Updated package.json to include react-native-gesture-handler and other dependencies. Enhanced the app's structure with new models and services for better data management.
current prod values
Add cdn url for cocoapods specs
We had changed parameter types for isLeprechaunActive, isAmoEnabled, and showLoginCta from BOOL* to BOOL in setConfigEnvironment and triggerLeadGenWithLoginCta methods for supporting the new architecture. We are reverting these changes so that we can first thoroughly validate these changes against both the old/new ARCHS and then proceed.
…w tracking - Replaced Mixpanel tracking calls in SCLoans with internal analytics events - Removed Mixpanel SDK dependency from gradle - Verified build and functionality on working version
|
React-Native Bridge for Android successfully propagating events from Native Android SDK(Producer) to Smart Investing Appln (Consumer): React-Native Bridge for IOS successfully propagating events from Native Android IOS(Producer) to Smart Investing Appln (Consumer): |
…intainability - Simplified event flow between native and JS layers - Improved code readability and reduced complexity - Easier to extend with new analytics events in future
…ved maintainability - Simplified event flow between native and JS layers - Improved code readability and reduced complexity - Easier to extend with new analytics events in future
…d the stringified payload
… to functional components
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Show resolved
Hide resolved
…ctly in React Native plugin
…proper ordering as per syntax
…de-react-native-0.79.4-dhruv-events: - Resolved Podfile.lock merge conflicts by taking upgrade branch dependencies - Fixed BOOL parameter syntax in RCT_REMAP_METHOD (removed incorrect pointer *) - Updated package.json script as per incoming change
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCLoansBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCLoansBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCLoansBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
|
Please remove all |
- Fix Kotlin syntax errors and formatting issues in bridge emitters - Remove unnecessary try-catch blocks for cleaner error handling - Update App.tsx for functional components - Replace SDK-supplied constants with JS constants for better consistency - Improve code readability and maintainability Affects: - Android: SCGatewayBridgeEmitter.kt, SCLoansBridgeEmitter.kt - iOS: SCGatewayEmitter.swift, SCLoansEmitter.swift - JS: SCGatewayEventEmitter.js, SCLoansEventEmitter.js - App: App.tsx
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCGatewayBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCLoansBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativesmallcasegateway/SCLoansBridgeEmitter.kt
Outdated
Show resolved
Hide resolved
types/index.d.ts
Outdated
| // Event managers and methods | ||
| SCGatewayEventManager: any; | ||
| SCLoansEventManager: any; | ||
| subscribeToGatewayEvents: (callback: (event: any) => void) => any; | ||
| unsubscribeFromGatewayEvents: (subscription: any) => void; | ||
| subscribeToLoansEvent: (callback: (event: any) => void) => any; | ||
| unsubscribeFromLoansEvent: (subscription: any) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types need to be generated properly. Take @LonelyCpp 's help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked and Updated.
types/index.d.ts
Outdated
| declare const SCGatewayEventManager: any; | ||
| declare const SCLoansEventManager: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types need to be generated properly. Take @LonelyCpp 's help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked and Updated.
…native-0.79.4-dhruv-events
ios/SCLoansEmitter.swift
Outdated
| let notificationName = Notification.Name(ScLoan.scLoansNotificationName.rawValue) | ||
|
|
||
| self.notificationObserver = NotificationCenter.default.addObserver( | ||
| forName: notificationName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| let notificationName = Notification.Name(ScLoan.scLoansNotificationName.rawValue) | |
| self.notificationObserver = NotificationCenter.default.addObserver( | |
| forName: notificationName, | |
| self.notificationObserver = NotificationCenter.default.addObserver( | |
| forName: ScLoan.scLoansNotificationName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done




No description provided.