Skip to content

Conversation

@dporwal-shipit
Copy link
Collaborator

No description provided.

aaditya-smallcase and others added 10 commits May 30, 2025 15:26
Use react-native 0.79.4 to setup the app
Updated the version of react-native-screens to ^3.34.0 in package.json and modified the Android build.gradle to include jcenter in the repositories list. Also, adjusted gradle.properties to disable new architecture and added artifactory credentials.
Swapped the API categories in PrivacyInfo.xcprivacy and updated the project.pbxproj to include PrivacyInfo.xcprivacy in the Resources build phase. Adjusted build settings to include new flags and development team information.
Added multiple screens and components for the smart investing app, including ConnectScreen, HoldingsScreen, and SmtScreen. Introduced context providers for environment and SST cart management. Integrated API functions for handling user interactions and data fetching. Updated package.json to include react-native-gesture-handler and other dependencies. Enhanced the app's structure with new models and services for better data management.
Add cdn url for cocoapods specs
@dporwal-shipit dporwal-shipit self-assigned this Jul 30, 2025
indrajit-roy-sc and others added 12 commits August 1, 2025 05:54
We had changed parameter types for isLeprechaunActive, isAmoEnabled, and showLoginCta from BOOL* to BOOL in setConfigEnvironment and triggerLeadGenWithLoginCta methods for supporting the new architecture.

We are reverting these changes so that we can first thoroughly validate these changes against both the old/new ARCHS and then proceed.
…w tracking

- Replaced Mixpanel tracking calls in SCLoans with internal analytics events
- Removed Mixpanel SDK dependency from gradle
- Verified build and functionality on working version
@dporwal-shipit dporwal-shipit changed the title Upgrade react native 0.79.4 dhruv events Upgrade react native 0.79.4 + Removed Mixpanel from Native Android/IOS SDKs Aug 26, 2025
@dporwal-shipit dporwal-shipit marked this pull request as draft August 26, 2025 09:50
@dporwal-shipit
Copy link
Collaborator Author

dporwal-shipit commented Aug 26, 2025

React-Native Bridge for Android successfully propagating events from Native Android SDK(Producer) to Smart Investing Appln (Consumer):

For SCGateway:
image

For SCLoans:
image

React-Native Bridge for IOS successfully propagating events from Native Android IOS(Producer) to Smart Investing Appln (Consumer):

For SCGateway:
image

For SCLoans:
image

…intainability

- Simplified event flow between native and JS layers
- Improved code readability and reduced complexity
- Easier to extend with new analytics events in future
…ved maintainability

- Simplified event flow between native and JS layers
- Improved code readability and reduced complexity
- Easier to extend with new analytics events in future
…de-react-native-0.79.4-dhruv-events:

- Resolved Podfile.lock merge conflicts by taking upgrade branch dependencies
- Fixed BOOL parameter syntax in RCT_REMAP_METHOD (removed incorrect pointer *)
- Updated package.json script as per incoming change
@indrajit-roy-sc
Copy link
Collaborator

Please remove all try-catch blocks where none of the internal function calls can throw.

- Fix Kotlin syntax errors and formatting issues in bridge emitters
- Remove unnecessary try-catch blocks for cleaner error handling
- Update App.tsx for functional components
- Replace SDK-supplied constants with JS constants for better consistency
- Improve code readability and maintainability

Affects:
- Android: SCGatewayBridgeEmitter.kt, SCLoansBridgeEmitter.kt
- iOS: SCGatewayEmitter.swift, SCLoansEmitter.swift
- JS: SCGatewayEventEmitter.js, SCLoansEventEmitter.js
- App: App.tsx
types/index.d.ts Outdated
Comment on lines 53 to 59
// Event managers and methods
SCGatewayEventManager: any;
SCLoansEventManager: any;
subscribeToGatewayEvents: (callback: (event: any) => void) => any;
unsubscribeFromGatewayEvents: (subscription: any) => void;
subscribeToLoansEvent: (callback: (event: any) => void) => any;
unsubscribeFromLoansEvent: (subscription: any) => void;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types need to be generated properly. Take @LonelyCpp 's help.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked and Updated.

types/index.d.ts Outdated
Comment on lines 3 to 4
declare const SCGatewayEventManager: any;
declare const SCLoansEventManager: any;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types need to be generated properly. Take @LonelyCpp 's help.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked and Updated.

@indrajit-roy-sc indrajit-roy-sc changed the base branch from upgrade/react-native-0.79.4 to development September 9, 2025 04:24
@indrajit-roy-sc indrajit-roy-sc changed the base branch from development to upgrade/react-native-0.79.4 September 9, 2025 04:24
@dporwal-shipit dporwal-shipit changed the base branch from upgrade/react-native-0.79.4 to development September 9, 2025 04:27
Comment on lines 68 to 71
let notificationName = Notification.Name(ScLoan.scLoansNotificationName.rawValue)

self.notificationObserver = NotificationCenter.default.addObserver(
forName: notificationName,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let notificationName = Notification.Name(ScLoan.scLoansNotificationName.rawValue)
self.notificationObserver = NotificationCenter.default.addObserver(
forName: notificationName,
self.notificationObserver = NotificationCenter.default.addObserver(
forName: ScLoan.scLoansNotificationName,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants