Open
Conversation
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
| language: Optional[str] = "en", | ||
| output_format: Optional[str] = "wav" | ||
| ) -> None: | ||
| def __init__(self, api_key: str = None) -> None: |
There was a problem hiding this comment.
Correctness: The signature change in WavesClient.__init__ (line 13) removes several parameters (model, sample_rate, voice_id, etc.) that were previously accepted. This is a breaking change that will cause a TypeError for any existing callers passing these arguments, leading to runtime crashes upon upgrading the SDK.
🤖 AI Agent Prompt for Cursor/Windsurf
📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue
In `smallestai/waves/waves_client.py` at the `WavesClient.__init__` definition (around line 13), restore backward compatibility by re-adding the previous optional parameters or by accepting `**kwargs` and ignoring/handling them. Ensure callers passing old args do not raise `TypeError`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Changes
Client object only takes API key
feature params need to be given in transcribe/synthesize function calls
Supported languages can be different for different models
Handling and validation for lightning v3.1 and v2 (consistency, similarity, enhancement supported)
Removed support for lightning and lightning-large
If no model provided for TTS, it defaults to v3.1
EntelligenceAI PR Summary
This PR upgrades the Waves SDK to support new model versions (lightning-v3.1, pulse) and simplifies the API by removing configuration objects in favor of explicit parameters.