Add provisionerName to webhook request for x509 and SSH#2618
Merged
maraino merged 2 commits intosmallstep:masterfrom Mar 31, 2026
Merged
Add provisionerName to webhook request for x509 and SSH#2618maraino merged 2 commits intosmallstep:masterfrom
maraino merged 2 commits intosmallstep:masterfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature:
Add provisionerName to webhook request for x509 and SSH
Pain or issue this feature alleviates:
The
provisionerNamefield inRequestBody(webhook/types.go:86) is only populated for SCEP webhooks (authority/provisioner/scep.go:160). For X509 and SSH webhooks, the field is always empty despite the provisioner being available as a parameter in all four call sites (callEnrichingWebhooksX509,callAuthorizingWebhooksX509,callEnrichingWebhooksSSH,callAuthorizingWebhooksSSH). This makes it impossible for webhook servers to implement per-provisioner logic (e.g., enforcing different key policies for different ACME provisioners).Why is this important to the project (if not answered above):
The field already exists in the struct and is documented as part of the webhook request body. Not populating it for X509/SSH breaks the reasonable expectation that all webhook types provide the same base context to webhook servers.
Is there documentation on how to use this feature? If so, where?
The webhook request body is documented at https://smallstep.com/docs/step-ca/webhooks/ but does not currently mention
provisionerName. The field exists in theRequestBodystruct (webhook/types.go:86) and is already populated for SCEP webhooks, but is undocumented.In what environments or workflows is this feature supported?
All provisioner types that trigger X509 or SSH enriching/authorizing webhooks (ACME, JWK, OIDC, x5c, etc.). SCEP already works and is unchanged.