feat: add calendar color prop #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default authentication type is "basic", but some CalDav servers have other authentication types (like "digest", in my case).
When creating a calendar you can provide a resource name in the MakeCalendarRequestVO, but this resource name was ignored when doing the actual call to the server. This commit checks if you have provided a resource name, and will try to create a calendar using that resource name if you did. If you did not provide a resource name, it will revert to the previous behaviour of using a UID for the calendar name.
It accepts a 'body' and (return) 'code' argument, but in the code here 'calendar_url' was erroneously passed in as first argument
In the GetCalendarRequest and GetCalendarsRequest you use the {http://calendarserver.org/ns/:} namespace, but that one was not declared at the top of the XML document.
Prevents SabreDAV from recognizing the request for a ctag
Allow authentication types other than 'basic'
Implement missing date range filter
No longer ignore user provided 'resourcename'
CalendarDeletedResponse accepts 2 arguments, not 3
Add omitted namespace
Some CalDAV servers only return namespaced XML, and simplexml_load_string deals with this kind of XML slightly differently, which means we can’t easily convert it to JSON without first stripping the namespaces (unfortunately).
Without this change the library doesn’t work in SabreDAV
The tests were very tailored for iCloud. I adjusted them to run on more generic CalDav servers as well.
To access the requested getetag prop from Facade/Requests/GetCalendarRequest.php
Accomodated for status being nested in propstat element in Apple ICalendar CalendarSyncInfoResponse ETagEntityResponse body
Yahoo returns the HTTP statuses in lowercase, which doesnt match with the uppercase HTTP statuses.
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
- Add getSupportedComponents() method to parse component types - Add supportsEvents() helper to check VEVENT support - Enables filtering of VTODO-only calendars from event views
- Add current-user-privilege-set to GetCalendarsRequest - Add getCurrentUserPrivileges() method to parse user permissions - Add isWritable() helper to check write access - Enables UI indicators for read-only calendars
Similar to X-MASTER-RRULE, this captures the original DTSTART from the series master event before expansion and attaches it to each expanded instance. This allows frontends to correctly update recurring event series without accidentally shifting the series start date to the instance date being edited.
Add WebDAV MOVE method support to enable atomic event moves between CalDAV calendars. This is especially important for iCloud which uses account-unique UIDs and fails with DELETE+CREATE approach. - Add Move constant to HttpMethods - Add Destination and Overwrite headers to Headers - Add createMoveRequest to RequestFactory - Add EventMovedResponse class - Add moveEvent method to CalDavClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds calendar-color prop in GetCalendarsRequest for iCloud caldav