Skip to content

fix: skip redundant save on Entity.load() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deucalioncodes merged 1 commit into from
Mar 18, 2026
Merged

fix: skip redundant save on Entity.load() #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ic_python_db/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ class User(Entity):
setattr(self, k, v)
self._do_not_save = False

self._save()
if not self._loaded:
self._save()

@classmethod
def new(cls, **kwargs):
Expand Down Expand Up @@ -386,6 +387,10 @@ def load(
# Create instance first
entity = cls(**data, _loaded=True)

# If migration was applied, persist the migrated data
if stored_version != current_version:
entity._save()

# Restore legacy "relations" block if present in serialized data.
# Otherwise keep the _relations that __init__ already populated
# via relationship descriptors (OneToMany, ManyToOne, etc.).
Expand Down
Loading