Exclude more files from the compilation#1374
Open
GabsPuNs wants to merge 4 commits intosmartcmd:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR excludes more Xbox 360 files to save space.
Changes
Previous Behavior
Previously, Xbox 360 sound files and the unused "gamerules", "tutorial" (is not the tutorial folder from windows64media) and "trial" folder in common folder were not excluded.
Root Cause
These files were not excluded from CopyAssets.cmake and Windows.cmake.
New Behavior
Now, music files with the following extensions are excluded from the compilation: ".xgs", ".xwb", ".xsb", ".xap", and "*.xzp".
Fix Implementation
Xbox 360 music files extensions were added to ASSET_EXCLUDE_FILES and gamerules folder was added to ASSET_EXCLUDE_FOLDERS. _MINECRAFT_CLIENT_WINDOWS_COMMON_RES_AUDIO was also removed from Windows.cmake
AI Use Disclosure
I didn't use AI for this
Note: If you're using Visual Studio and the compile option isn't showing up, simply switch from release to debug or vice versa to update the configuration.