Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements advanced tooltips (toggled by F3+H) into the client, and uncomments & fixes code leftover for advanced tooltips
Changes
Previous Behavior
ItemInstance's getHoverText for advanced tooltips was commented out, and was the literal copy and pasted Java code. And there was no handling for F3+H
New Behavior
Converted the previously Java code to work with C++, adjusting to work with htmlstring and using swprintf_s.
Options now has an
advancedTooltipsvalue, defaulting to false.Windows64_Minecraft.cpp now has handling for F3+H combo, and also later combos if we ever want to add them.
Now, when a user has advanced tooltips on, it shows the items id, and aux value.
if using a tool (such as a pickaxe) it will also show durability. These parts were not added by me, and were simply commented out/already there jsut not used.
8mb.video-4AG-0MyqdoWj.mp4
AI Use Disclosure
no ai