Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it to where XUID's cannot be logged by other clients. This doesn't break anything serverside.
This fix applies serverside, old clients before this fix should not be able to log XUID's either
Changes
Previous Behavior
Before, XUID"s were passed to all clients, which could be stolen by iterating through
pMinecraft->level->playersin your clientExample:
Root Cause
Its old. And you were never intended to be able to spoof your XUID
New Behavior
When add player packet is passed to other clients, the XUID is now replaced with INVALID_XUID (only to clients, server still knows the actual XUID)
Example attempt to log with an XUID logger:
Fix Implementation
remove getting xuid in getAddEntityPacket() (this is what gets the actual packet to send to other clients for an entity beigna dded)
AI Use Disclosure
no ai