Fancy Graphics, Old Swing & Smooth Lighting checkboxes in options.#894
Closed
MijaeLio wants to merge 34 commits intosmartcmd:mainfrom
Closed
Fancy Graphics, Old Swing & Smooth Lighting checkboxes in options.#894MijaeLio wants to merge 34 commits intosmartcmd:mainfrom
MijaeLio wants to merge 34 commits intosmartcmd:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amongaswag.mp4
swing.mp4
Description
Introduces checkboxes for Ambient Occlusion & Fancy Graphics, for enabling and disabling them.
Changes
Previous Behavior
Ambient Occlusion and Fancy Graphics options were unused, left in the code but working.
Root Cause
There wasn't any option in-game to switch them.
New Behavior
You get new checkboxes for Graphics options for AO and FG.
Fix Implementation
Edited SWF files to add the checkboxes, Consoles_app.cpp so the settings save properly and for having effect on those options in-game, SettingsGraphicsMenu to add the new checkboxes in the code, defined GAMESETTING for the new options using uiBitmaskValues, restored function for AO in TileRenderer so it matches with the option.
AI Use Disclosure
No AI was used.
Related Issues