Open
Conversation
Race Chain.getTransactions and API.getMessageById, and print however it can
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 andrevmatos, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Coverage Report |
AndresJulia
approved these changes
Feb 16, 2026
aelmanaa
requested changes
Feb 16, 2026
| // source = await getChain(sourceNetwork.chainId) | ||
| } | ||
| } | ||
| const request = await request$ |
Collaborator
There was a problem hiding this comment.
we might want to handle the case where both requests fail. It will be confusing for the user to see at the same an rpc error and an api error
| try { | ||
| source = await getChain(request.lane.sourceChainSelector) | ||
| } catch { | ||
| // pass |
Collaborator
There was a problem hiding this comment.
can we at least get here a logger.info or logger.debug?
| const apiClient = CCIPAPIClient.fromUrl(undefined, ctx) | ||
| if (isHexString(argv.txHashOrId, 32)) { | ||
| request$ = Promise.any([request$, apiClient.getMessageById(argv.txHashOrId)]) | ||
| // source = await getChain(sourceNetwork.chainId) |
Collaborator
There was a problem hiding this comment.
should we remove this line entirely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
showto racegetMessageByIdin parallel withChain.getTransactionsprettyTableoutput