Add Canton Blockchain #2332
Draft
Add Canton Blockchain #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
reviewed
Dec 18, 2025
Comment on lines
+51
to
+55
| script += fmt.Sprintf(` | ||
| # Participant %02[1]d | ||
| echo "Checking ${CANTON_PARTICIPANT_GRPC_HEALTHCHECK_PORT_PREFIX}%02[1]d" | ||
| grpcurl -plaintext "localhost:${CANTON_PARTICIPANT_GRPC_HEALTHCHECK_PORT_PREFIX}%02[1]d" grpc.health.v1.Health/Check | ||
| `, i) |
There was a problem hiding this comment.
Does this Sprintf work as expected? I see 3 format verbs (%02[1]d) but just one arg in the varargs section of the args (i rather than i,i,i)
Member
Author
There was a problem hiding this comment.
Yeah, arguments can be explicitly indexed: https://pkg.go.dev/fmt#hdr-Explicit_argument_indexes
This seems cleaner than repeating the same argument i all over again
| if err != nil { | ||
| return nil, err | ||
| } | ||
| _ = c |
There was a problem hiding this comment.
You could do _, err := ... on line 30 to avoid doing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce support for the Canton blockchain network within a blockchain simulation framework. This includes defining new constants for the Canton type and family, extending validation for the Canton network type, and implementing the necessary container setup for running a Canton network. These updates allow users to simulate and interact with Canton networks, enhancing the framework's versatility and support for different blockchain technologies.
What
framework/components/blockchain/blockchain.go
TypeCantonconstant to define Canton type.FamilyCantonconstant to define Canton family.Typefield validation inInputstruct to includecanton.NumberOfValidatorsfield toInputstruct for Canton specific configuration.TypeCantoninNewWithContextfunction to handle Canton network setup.TypeCantonhandling inTypeToFamilyfunction to map Canton type to its family.framework/components/blockchain/canton.go
framework/components/blockchain/canton/canton.go
framework/components/blockchain/canton/nginx.go
framework/components/blockchain/canton/postgres.go
framework/components/blockchain/canton/splice.go