Skip to content

Add some error handling and retries when creating a new connection #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aigarius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some error handling and retries when creating a new connection #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions django_mysqlpool/backends/mysqlpool/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
# Needs to be less than MySQL connection timeout (server setting). The default is 120,
# so default to 119.
MYSQLPOOL_TIMEOUT = 119

# Times to try reconnecting to the database if the connection goes stale in the pool
MYSQLPOOL_RETRY = 5

def isiterable(value):
"Checks if the provided value is iterable."
Expand Down Expand Up @@ -57,9 +58,11 @@ def __hash__(self):
def get_pool():
"Creates one and only one pool using the configured settings."
global MYSQLPOOL
global MYSQLPOOL_RETRY
if MYSQLPOOL is None:
backend = getattr(settings, 'MYSQLPOOL_BACKEND', MYSQLPOOL_BACKEND)
backend = getattr(pool, backend)
MYSQLPOOL_RETRY = getattr(settings, 'MYSQLPOOL_RETRY', MYSQLPOOL_RETRY)
kwargs = getattr(settings, 'MYSQLPOOL_ARGUMENTS', {})
kwargs.setdefault('poolclass', backend)
# The user can override this, but set it by default for safety.
Expand All @@ -81,7 +84,18 @@ def connect(**kwargs):
# compatible with their serialization.
kwargs['conv'] = HashableDict(conv)
# Open the connection via the pool.
return get_pool().connect(**kwargs)
retry = MYSQLPOOL_RETRY
connection = None
while(retry and not connection):
try:
connection = get_pool().connect(**kwargs)
except:
connection = None
retry -= 1
if connection:
return connection
else:
return get_pool().connect(**kwargs)
Copy link

@variable variable Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here should raise exception instead of "trying again"



# Monkey-patch the regular mysql backend to use our hacked-up connect() function.
Expand Down