[tuya] Add support for protocol version 3.5#626
Merged
J-N-K merged 3 commits intosmarthomej:5.0.xfrom May 4, 2025
Merged
Conversation
Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com>
J-N-K
reviewed
May 4, 2025
| } else { | ||
| byte[] decodedMessage = protocol == V3_4 ? CryptoUtil.decryptAesEcb(payload, sessionKey, true) | ||
| : CryptoUtil.decryptAesEcb(payload, sessionKey, false); | ||
| byte[] decodedMessage = protocol == V3_5 ? CryptoUtil.decryptAesGcm(payload, sessionKey, header, null) : protocol == V3_4 ? CryptoUtil.decryptAesEcb(payload, sessionKey, true) : CryptoUtil.decryptAesEcb(payload, sessionKey, false); |
Member
There was a problem hiding this comment.
That's really hard to read. What do you think of using an enhanced switch statement?
byte[] decodedMessage = switch (protocol) {
case V3_5 -> CryptoUtil.decryptAesGcm(payload, sessionKey, header, null);
case V3_4 -> CryptoUtil.decryptAesEcb(payload, sessionKey, true);
default -> CryptoUtil.decryptAesEcb(payload, sessionKey, false);
}
| } | ||
|
|
||
| Optional<byte[]> bufferOptional = protocol == V3_4 ? encode34(msg.commandType, payloadBytes, sessionKey) | ||
| Optional<byte[]> bufferOptional = protocol == V3_5 ? encode35(msg.commandType, payloadBytes, sessionKey) : protocol == V3_4 ? encode34(msg.commandType, payloadBytes, sessionKey) |
Member
|
Please also run |
Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com>
Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com>
J-N-K
pushed a commit
that referenced
this pull request
May 4, 2025
* [tuya] Add support for protocol version 3.5 Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com> * [tuya] Fix long ternary operators Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com> * [tuya] Apply spotless Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com> --------- Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com>
J-N-K
pushed a commit
that referenced
this pull request
May 4, 2025
* [tuya] Add support for protocol version 3.5 Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com> * [tuya] Fix long ternary operators Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com> * [tuya] Apply spotless Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com> --------- Signed-off-by: Andriy Yemets <cyborg.andy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #603