feat: add support for add and remove report scope#124
Open
smcgowan-smartsheet wants to merge 11 commits intosmartsheet:mainlinefrom
Open
feat: add support for add and remove report scope#124smcgowan-smartsheet wants to merge 11 commits intosmartsheet:mainlinefrom
smcgowan-smartsheet wants to merge 11 commits intosmartsheet:mainlinefrom
Conversation
Contributor
Re-reviewed at commit f1f5f69. Fixed 2 issues (
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
fix linting issues
fix double marshalling issue
update documentation
update documentation
Contributor
Reviewed at commit c42e77c. All previously flagged issues from earlier reviews have been resolved. Found one minor issue in the current changes:
Additional recommendations (require changes to files not modified in this PR):
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
remove unused import
keep imports consistent
fix imports order
Added type definitions
Added type definitions
remove tailing whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding
Type of Change
What Changes Were Made
Adding support for two additional endpoints which are to be added to the public API
Why These Changes Were Made
Ensuring SDKs maintain parity with the public API
Testing
Added wiremock testing for the endpoints
Checklist
docs-source/(see Documentation guidelines)