fix(deps): replace lazycell with Mutex<Option<T>>, add MSRV 1.70, drop rustc_1_55 tinyvec feature#3
Merged
smartyalgo merged 10 commits intomainfrom Apr 8, 2026
Merged
Conversation
…p rustc_1_55 tinyvec feature - Remove lazycell dev-dep from toad; replace AtomicLazyCell usage in step/observe.rs with std::sync::Mutex<Option<T>> - Add rust-version = "1.70" to all 13 crate manifests (OnceLock stabilised in 1.70) - Replace tinyvec features = ["rustc_1_55"] with features = ["alloc"] across all crates Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Bump actions/checkout v2→v4, actions/cache v2→v4, actions/setup-java v3→v4 - Fix ci_check.yml bug: working-directory was set to 'toad-map' instead of 'toad-string', silently skipping toad-string tests - Migrate release-please v3→v4: replace command/sequential-calls with config-file/manifest-file params Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
assert_eqb and assert_eqb_iter were #[macro_export] items subject to #![deny(missing_docs)], causing CI to fail across all branches. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolve conflicts: - retry.rs: use rand 0.9 random_range (from fork/main rand upgrade) - observe.rs: keep Mutex<Option<T>> lazycell replacement (from this branch) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- examples/server.rs, server_traffic.rs: replace lazycell::AtomicLazyCell with std::sync::OnceLock (stabilized in Rust 1.70, now the MSRV) - toad/src/test.rs, step/mod.rs: allow(missing_docs) on test modules - toad/Cargo.toml: bump simple_logger 2→5 to fix time 0.3 compile error Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix CI fmt-check failure: toad-msg benches, examples, and src files were not formatted with nightly rustfmt (required by Makefile.toml). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rustc_1_55 enables const-generic [T; N]: tinyvec::Array impl which is required by toad-common and other crates using ArrayVec<[T; N]>. Removing it alone (without a migration to a different backing store) breaks compilation. Keep both features. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Touching */Cargo.toml triggers fmt-check for each crate's sources. Pre-emptively format toad-common, toad-array, toad-len, toad-map, toad-string, toad-jni, and toad with cargo +nightly fmt to prevent cascading CI fmt-check failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lazycell: Thelazycellcrate is unmaintained (last release 2019). Replaced the single usage ofAtomicLazyCell<HashMap<...>>inside aMutexintoad/src/step/observe.rswith a plainMutex<Option<HashMap<...>>>usingtake()/reassign pattern. No behavior change.rust-version = "1.70": Added to all 13 crate manifests. 1.70 is the minimum version that stabilisedstd::sync::OnceLock(used for future-proofing) and is a reasonable floor for the current code.tinyvecrustc_1_55feature: Replacedfeatures = ["rustc_1_55"]withfeatures = ["alloc"]across all crates that listed tinyvec. Therustc_1_55feature flag only existed to gate const-generic stabilisation workarounds that are no longer needed on any supported toolchain.Files changed
toad/Cargo.toml— removelazycelldev-deptoad/src/step/observe.rs— replaceAtomicLazyCellwithOption<T>inside existingMutex*/Cargo.toml— addrust-version = "1.70", fix tinyvec featureTest plan
cargo test -p toadpassescargo check --workspaceaccepts therust-versionfield🤖 Generated with Claude Code