updating openmdao tests to work with upcoming version release#358
Merged
A-CGray merged 2 commits intosmdogroup:masterfrom Feb 27, 2025
Merged
updating openmdao tests to work with upcoming version release#358A-CGray merged 2 commits intosmdogroup:masterfrom
A-CGray merged 2 commits intosmdogroup:masterfrom
Conversation
A-CGray
reviewed
Feb 27, 2025
| form=self.fd_form, | ||
| step=self.dh, | ||
| # TODO: For now we have to skip the solver partials until we implement a proper Jacobian transpose routine | ||
| excludes=["*.coupling.solver"], |
Contributor
There was a problem hiding this comment.
Does this skip all partial checks for the solver? Are there not some we can still test (e.g residual partials w.r.t DVs and node coodinates)
Collaborator
Author
There was a problem hiding this comment.
Unfortunately, OpenMDAO doesn't allow for that level of granularity at this time. You can only exclude on a component level
Contributor
There was a problem hiding this comment.
Damn, guess we need to get back to #336 at some point soon then
A-CGray
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pr should fix issues that will arise when OpenMDAO PR #3465 is merged in