Draft
Conversation
timryanb
reviewed
Sep 26, 2025
timryanb
reviewed
Sep 26, 2025
timryanb
reviewed
Sep 26, 2025
Contributor
Author
|
Just for the record, since this was mentioned offline, I plan to add an integration test as well. |
Collaborator
|
@eirikurj I would suggest: |
Contributor
Author
|
I have renamed the classes as suggested and added a deprecation warning for the previous name. Working on adding constraint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add a lamination parameter constitutive class
TACSLamParamAllShellConstitutive. This implementation is based on an implementation from the original TACS.In this class there are 7 design variables, 6 lamination parameters plus thickness, which differs from the existing implementation
TACSLamParamShellConstitutivethat has 6 DVs (2 lamination parameters + 3 laminate fractions + thickness).Added basic tests for both classes since I noticed that
TACSLamParamShellConstitutivedid not have any.Regarding the class name,
TACSLamParamAllShellConstitutiveI am not quite happy with it and open to suggestions or strategies that we can use when naming similar classes. The new one hasAllin the name to indicate that all LPs (given the approximations) are parametrized. Thought about renaming the existing one to includeFracin the name, but that will break backwards compatibility.