Skip to content

INP: Avoid command presence to map btn #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasere-smeup merged 1 commit into from
Apr 30, 2026
Merged

INP: Avoid command presence to map btn #2851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions packages/ketchup/src/components/kup-input-panel/kup-input-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,8 +875,8 @@ export class KupInputPanel {
const value = isFormattableType
? getCellValueForDisplay(column, cell)
: cell.decode
? cell.decode
: cell.value;
? cell.decode
: cell.value;

return (
<span class={classList.join(' ')} id={column.name}>
Expand Down Expand Up @@ -1149,8 +1149,8 @@ export class KupInputPanel {
+field.colSpan > 0
? field.colSpan
: !(+field.colSpan > 0) && !(+field.colStart > 0)
? 1
: null;
? 1
: null;

const colStart = colSpan ? `span ${colSpan}` : `${field.colStart}`;

Expand All @@ -1160,8 +1160,8 @@ export class KupInputPanel {
+field.rowSpan > 0
? field.rowSpan
: !(+field.rowSpan > 0) && !(+field.rowStart > 0)
? 1
: null;
? 1
: null;

const rowStart = rowSpan ? `span ${rowSpan}` : `${field.rowStart}`;

Expand Down Expand Up @@ -1200,8 +1200,8 @@ export class KupInputPanel {
length = fieldCell.cell.value
? fieldCell.cell.value.length
: field.absoluteLength > 8
? field.absoluteLength
: 8;
? field.absoluteLength
: 8;
} else {
length = field.absoluteLength;
}
Expand All @@ -1214,11 +1214,11 @@ export class KupInputPanel {
fieldCell.cell.shape === FCellShapes.LABEL
? getLabelAbsoluteWidth(length)
: fieldCell.cell.shape === FCellShapes.CHECKBOX
? 15
: getAbsoluteWidth(
length,
graphicShapeHasIcon(fieldCell.cell.shape)
);
? 15
: getAbsoluteWidth(
length,
graphicShapeHasIcon(fieldCell.cell.shape)
);
const absoluteHeight = getAbsoluteHeight(field.absoluteHeight);
const absoluteTop = getAbsoluteTop(
field.absoluteRow,
Expand Down Expand Up @@ -1548,20 +1548,14 @@ export class KupInputPanel {
};

if (cell.data.mappedCommandId) {
const concurrentCommand = this.data.setup?.commands?.find(
(command) => command.value === cell.data.mappedCommandId
);

if (concurrentCommand) {
cell.isEditable = true;
cell.data.onClick = () => {
this.#getFunctionOnClickBTN(cell, concurrentCommand.value);
};
cell.isEditable = true;
cell.data.onClick = () => {
this.#getFunctionOnClickBTN(cell, cell.data.mappedCommandId);
};

this.data.setup.commands = this.data.setup.commands.filter(
(command) => command.value !== concurrentCommand.value
);
}
this.data.setup.commands = this.data?.setup?.commands?.filter(
(command) => command.value !== cell.data.mappedCommandId
);
}

return {
Expand Down Expand Up @@ -2020,10 +2014,10 @@ export class KupInputPanel {
: cell.data?.data?.['kup-list'];
if (kupListData) {
kupListData.data = filteredRows?.length
? (this.#optionsTreeComboAdapter(
? this.#optionsTreeComboAdapter(
visibleColumnsOptions,
cell.value
) ?? [])
) ?? []
: [];
kupListData.options = options?.columns ?? [];
} else {
Expand Down Expand Up @@ -2096,10 +2090,10 @@ export class KupInputPanel {
// Update the autocomplete list data
const kupListData = targetCell.data.data['kup-list'];
kupListData.data = filteredRows.length
? (this.#optionsTreeComboAdapter(
? this.#optionsTreeComboAdapter(
visibleColumnsOptions,
cellValue
) ?? [])
) ?? []
: [];
kupListData.options = options.columns ?? [];

Expand Down
Loading