LS26001067: return default message on unknown date format#2853
Merged
pasere-smeup merged 1 commit intodevelopfrom May 5, 2026
Merged
LS26001067: return default message on unknown date format#2853pasere-smeup merged 1 commit intodevelopfrom
pasere-smeup merged 1 commit intodevelopfrom
Conversation
andraasi
requested review from
Leonardo-Signorelli,
lucafoscili and
pasere-smeup
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important improvement to the
KupDatesdate formatting logic. The change ensures that if the date parsing fails and returnsnullorundefined, the method will now return a clear error message instead of causing a runtime error.toLocaleStringcall in theKupDatesclass: If the date cannot be parsed, the method now returns a descriptive error message instead of throwing an exception.