Skip to content

Fix Python version setup in GitHub Actions #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
+6 −7
Closed

Fix Python version setup in GitHub Actions #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da0b74f
Use correct python version and allow pre-release versions
jonathan343 Aug 14, 2025
da4a859
Remove UV_SYSTEM_PYTHON usage
jonathan343 Aug 14, 2025
dd6f1f6
just testing stuff out; this is weird
jonathan343 Aug 14, 2025
929185f
more testing
jonathan343 Aug 14, 2025
2da2b95
revert changes and remove .python-version file
jonathan343 Aug 18, 2025
b616ce6
Fix typing issues in python 3.13 and 3.14
jonathan343 Aug 18, 2025
630818b
test new workflow
jonathan343 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: Set up JDK 17
uses: actions/setup-java@v4
Expand Down
1 change: 0 additions & 1 deletion .python-version
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions packages/smithy-aws-event-stream/src/smithy_aws_event_stream/_private/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,8 @@ def begin_struct(self, schema: "Schema") -> Iterator[ShapeSerializer]:
# Note that if we're serializing an operation input or output, it won't be a
# union at all, so this won't get triggered. Thankfully, that's what we want.
if schema.shape_type is ShapeType.UNION:
try:
yield self
finally:
return
yield self
return

headers: dict[str, HEADER_VALUE] = {}

Expand Down
4 changes: 2 additions & 2 deletions packages/smithy-core/src/smithy_core/aio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ async def _handle_execution[I: SerializeableShape, O: DeserializeableShape](
transport_request=interceptor.modify_before_retry_loop(request_context),
)

return await self._retry(call, request_context, request_future)
return await self._retry(call, request_context, request_future) # type: ignore[return-value]
except Exception as e:
return OutputContext(
request=request_context.request,
Expand All @@ -325,7 +325,7 @@ async def _retry[I: SerializeableShape, O: DeserializeableShape](
call: ClientCall[I, O],
request_context: RequestContext[I, TRequest],
request_future: Future[RequestContext[I, TRequest]] | None,
) -> OutputContext[I, O, TRequest | None, TResponse | None]:
) -> OutputContext[I, O, TRequest, TResponse | None]:
if not call.retryable():
return await self._handle_attempt(call, request_context, request_future)

Expand Down
Loading