Clarify Ankan wait calculation logic - no code changes needed#86
Closed
Copilot wants to merge 1 commit intofeat/add-feature-encodesfrom
Closed
Clarify Ankan wait calculation logic - no code changes needed#86Copilot wants to merge 1 commit intofeat/add-feature-encodesfrom
Copilot wants to merge 1 commit intofeat/add-feature-encodesfrom
Conversation
Copilot
AI
changed the title
[WIP] Update feedback on ML baseline and environment interaction logic
Clarify Ankan wait calculation logic - no code changes needed
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automated review flagged the Ankan after riichi wait calculation as potentially buggy due to apparent asymmetry between
hand_pre(13 tiles) andhand_post(10 tiles + meld). However, the implementation is correct.Analysis
The logic compares two valid post-action game states:
Both represent the hand state after the player's action, making this the correct comparison for the rule: "ankan after riichi is only allowed if it doesn't change waits."
Changes
No code changes were made. The current implementation in
native/src/state/legal_actions.rs:148-177correctly implements the standard Riichi Mahjong rule.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.