Open
Conversation
Update gradle things. - Had to set `duplicatesStrategy = 'INCLUDE'` to build on my machine. not 100% sure what this does, but seems to build correctly atm. Also, update usages of `PlayerListHeaderS2CPacket` where required (things changed 1.16 -> 1.17)
Author
|
Check build.gradle's |
Author
|
Note: these changes will be incompatible with 1.16, so if you want to keep support for 1.16 if/when you add new features, it might be worth merging these changes to new branch. |
Author
Upon doing further research, this seems to be a standard fix that many modders have made upon updating to 1.17. Should work as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update gradle things.
Update usages of
PlayerListHeaderS2CPacketto conform to 1.17 class spec.