Skip to content

Initial implementation for picture-in-picture mode #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oakamil wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Initial implementation for picture-in-picture mode #5

oakamil wants to merge 5 commits into from

Conversation

@oakamil
Copy link
Contributor

@oakamil oakamil commented Jan 7, 2026

A few tweaks might be desirable on top of this:

  • Right now when there's no slew request (with solution) I just show a spinner. We may want to differentiate between different states like I do on the OLED display mod. But I did feel like that wasn't necessary here.
  • If the drawer is expanded and then PIP mode is activated part of the drawer is covering the guidance display. This should be a simple fix to collapse the drawer.
  • I'm not sure why the text in PIP mode is white when not in night vision mode.
  • We may want to have a setting to enable/disable PIP mode auto-activation.
  • We may want to have an explicit entry point into PIP mode.

Omair Kamil and others added 4 commits January 6, 2026 22:34
Implement a picture-in-picture mode on Android for guidance.
b8ec980
@oakamil
Merge pull request #4 from oakamil/main
b705ff4 
Implement a picture-in-picture mode on Android for guidance.
Close drawer when entering PIP mode, and show a PIP button in the dra…
2e6bfdc 
…wer.
Miscellaneous UI fixes.
5713638 
- Update color for guidance to primary
- Navigate back to main page when entering/exiting PIP
- Await on PIP start when invoked from drawer
@oakamil
Copy link
Contributor Author

oakamil commented Jan 8, 2026

  • Fixed the issue with the expanded drawer, in addition to another view being open when entering PIP mode (navigate back to the root)
  • Fixed text being the correct color (magenta?)
  • Added explicit entry point into PIP mode via drawer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smroid smroid smroid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oakamil @smroid