Updated make_bedrock.py architecture#80
Merged
ghislainp merged 3 commits intosmrt-model:masterfrom Mar 26, 2026
Merged
Conversation
bedrock permittivities are moved to a permittivity/bedrock.py file make_bedrock function is updated
Contributor
Author
|
Additionally the DeprecationWarning are not showing for me. |
Member
|
as discussed, we'll use make_soil to work with bedrock permittivity. Could you remove completely the make_bedrock function, and run the tests. pytest is currently failing |
Unified soil and bedrock creation by mergind make_bedrock into make_soil Removed make_bedrock function Bedrock permittivities are now accessible to the make_soil function Creation of resolve_make_soil_permittivity_model helper function to acces correct permittivity model Updated make_soil tests
Contributor
Author
|
I removed completely make_bedrock, updated make_soil tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I updated the make_bedrock.py file to mimic the latest change in make_soil.py
Bedrocks permittivity are moved to permittivity/bedrock.py file.
make_bedrock function is updated in consequence.
Tell me if it is ok