Skip to content

ice permittivity Cuzzi1980 added#83

Merged
ghislainp merged 3 commits intosmrt-model:masterfrom
Rosh-2023:ice_permittivity
Mar 7, 2026
Merged

ice permittivity Cuzzi1980 added#83
ghislainp merged 3 commits intosmrt-model:masterfrom
Rosh-2023:ice_permittivity

Conversation

@Rosh-2023
Copy link
Copy Markdown

No description provided.

@hsignarg
Copy link
Copy Markdown
Collaborator

hsignarg commented Mar 3, 2026

Thank you for the contribution.

Could you please add a test in test_ice.py to:

  • Validate this function returns values consistent with Cuzzi et al. 1980;
  • Make sure that in the future , making modifications to the code will not break this function.
    This can be added as one or two parameter sets in the parametrization of test_ice_permittivity.

Also, I believe we should keep all permittivity computations to be functions of frequency and temperature for consistency. I understand this one is valid only for T = 100K. A solution could be to set temperature = 100 as default and to return an error if temperature is too far from 100.

@Rosh-2023
Copy link
Copy Markdown
Author

Thanks for the suggestions.
I’ve added the test case in test_ice.py and updated the function to accept temperature with a default of 100 K and return an error if temperature is too far from 100.

@ghislainp ghislainp merged commit b11f3f6 into smrt-model:master Mar 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants